Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74097 )
Change subject: mb/google/myst: Build for chromeOS
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74097/comment/daaa6db1_9726051d
PS4, Line 37: select VBOOT_STARTS_IN_BOOTBLOCK
This doesn't match Skyrim:
```
config VBOOT_STARTS_IN_BOOTBLOCK
bool
default y if VBOOT && !VBOOT_STARTS_BEFORE_BOOTBLOCK
```
Why the change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4b6917fe024067409bfbb3d2691c37759b5cace
Gerrit-Change-Number: 74097
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:37:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment