Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/12983 )
Change subject: intel/skylake: provide default VR configuration
......................................................................
Patch Set 2:
Note that PSI3 and PSI4 are not enabled for those defaults.
What was the reason for that? Many boards set it. CNL's vr_config even sets them by default. Should we update this on SKL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/12983
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02cb5fbdd4549cc827a0b0e4006bc21da4593b55
Gerrit-Change-Number: 12983
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Mon, 30 Mar 2020 22:26:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment