Attention is currently required from: Felix Singer, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email )
Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Wouldn't it be better to document what the ME and the HECI interface can be / is used for instead of […]
If users read documentation sure.
I was just thinking it should be one easy option - AFAIK, CMOS options can depend/control one another and having to change two options for one thing to work isn't user friendly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83265?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b
Gerrit-Change-Number: 83265
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 02 Jul 2024 20:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de