Change in coreboot[master]: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree
David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44542 )
Change subject: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree ......................................................................
mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree
Add PMC.MUX.CONx devices to devicetree for todor.
BUG=b:164941862 TEST=FW_NAME=todor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Iaef603553597685b03e805603352f38d70d65a5a --- M src/mainboard/google/volteer/variants/todor/overridetree.cb 1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/44542/1
diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index 8c0fb38..42d3f2f 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -127,5 +127,27 @@ device i2c 15 on end end end # I2C5 0xA0C6 + device pci 1f.2 hidden + # The pmc_mux chip driver is a placeholder for the + # PMC.MUX device in the ACPI hierarchy. + chip drivers/intel/pmc_mux + device generic 0 on + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "5" + register "usb3_port_number" = "1" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 0 on end + end + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "3" + register "usb3_port_number" = "2" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 1 on end + end + end + end + end # PMC end end
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44542 )
Change subject: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree ......................................................................
Patch Set 1: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44542 )
Change subject: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree ......................................................................
Patch Set 1: Code-Review+2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44542 )
Change subject: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree ......................................................................
Patch Set 1: Code-Review+1
Could we merge this? Thank you.
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44542 )
Change subject: mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree ......................................................................
mb/google/volteer/var/todor: Add PMC.MUX.CONx devices to devicetree
Add PMC.MUX.CONx devices to devicetree for todor.
BUG=b:164941862 TEST=FW_NAME=todor emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Iaef603553597685b03e805603352f38d70d65a5a Reviewed-on: https://review.coreboot.org/c/coreboot/+/44542 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/todor/overridetree.cb 1 file changed, 22 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index 8c0fb38..42d3f2f 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -127,5 +127,27 @@ device i2c 15 on end end end # I2C5 0xA0C6 + device pci 1f.2 hidden + # The pmc_mux chip driver is a placeholder for the + # PMC.MUX device in the ACPI hierarchy. + chip drivers/intel/pmc_mux + device generic 0 on + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "5" + register "usb3_port_number" = "1" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 0 on end + end + chip drivers/intel/pmc_mux/conn + register "usb2_port_number" = "3" + register "usb3_port_number" = "2" + # SBU is fixed, HSL follows CC + register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + device generic 1 on end + end + end + end + end # PMC end end
-
David Wu (Code Review) -
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)