Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64393 )
Change subject: mb/google/brya/var/crota: Add reset and enable delay time for rtd3-cold
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64393/comment/72bc32d2_0b1e2a66
PS3, Line 12: for
to
Done.
https://review.coreboot.org/c/coreboot/+/64393/comment/a44ba047_dc3cf92f
PS3, Line 12: Base
Based
Done.
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/64393/comment/19e11f49_0bbf15c8
PS3, Line 92: register "enable_delay_ms" = "20"
You do not mention the 20 ms in the commit message.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9bed46e801602f3f327753053ec6a1ceb0656e6
Gerrit-Change-Number: 64393
Gerrit-PatchSet: 4
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 17 May 2022 10:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment