Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75579?usp=email )
Change subject: mb/google/rex/variants/ovis: Add display configuration
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75579/comment/bceed482_cf04a20c :
PS1, Line 17: register "ddi_port_A_config" = "0"
: register "ddi_port_B_config" = "0"
u can drop this
Acknowledged
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75579/comment/d70cd1c4_2e9d813e :
PS5, Line 184: device ref ipu on end
can we submit a separate CL for this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75579?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f967b12b11c10a1a9329bfb42ebec5a8d7738f
Gerrit-Change-Number: 75579
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 10:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment