Change in coreboot[master]: vc/amd/fsp/picasso: mark remaining UPD header structs as __packed

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43658 )

Change subject: vc/amd/fsp/picasso: mark remaining UPD header structs as __packed
......................................................................

vc/amd/fsp/picasso: mark remaining UPD header structs as __packed

Change-Id: I5a97de69bfda201e039587c67037bfb93ca16c15
Signed-off-by: Felix Held 
---
M src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/43658/1

diff --git a/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h b/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
index dc3f946..c477a4f 100644
--- a/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
+++ b/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
@@ -27,7 +27,7 @@
    EnumInitPhaseEndOfFirmware		= 0xF0
 } FSP_INIT_PHASE;

-typedef struct {
+typedef struct __packed {
    uint64_t	Signature;
    uint8_t		Revision;
    uint8_t		Reserved[23];
@@ -35,7 +35,7 @@

_Static_assert(sizeof(FSP_UPD_HEADER) == 32, "FSP_UPD_HEADER not packed");

-typedef struct {
+typedef struct __packed {
    uint8_t		Revision;
    uint8_t		Reserved[3];
    void		*NvsBufferPtr;

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43658 )

Change subject: vc/amd/fsp/picasso: mark remaining UPD header structs as __packed
......................................................................

Patch Set 2: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43658 )

Change subject: vc/amd/fsp/picasso: mark remaining UPD header structs as __packed
......................................................................

vc/amd/fsp/picasso: mark remaining UPD header structs as __packed

Change-Id: I5a97de69bfda201e039587c67037bfb93ca16c15
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43658
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h b/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
index dc3f946..c477a4f 100644
--- a/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
+++ b/src/vendorcode/amd/fsp/picasso/fsp_h_c99.h
@@ -27,7 +27,7 @@
    EnumInitPhaseEndOfFirmware		= 0xF0
 } FSP_INIT_PHASE;

-typedef struct {
+typedef struct __packed {
    uint64_t	Signature;
    uint8_t		Revision;
    uint8_t		Reserved[23];
@@ -35,7 +35,7 @@

_Static_assert(sizeof(FSP_UPD_HEADER) == 32, "FSP_UPD_HEADER not packed");

-typedef struct {
+typedef struct __packed {
    uint8_t		Revision;
    uint8_t		Reserved[3];
    void		*NvsBufferPtr;