Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Wonkyu Kim.
Jérémy Compostella has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84229?usp=email )
Change subject: libpayload: add more condition to check valid PCI device id
......................................................................
Patch Set 3:
(3 comments)
File payloads/libpayload/drivers/usb/usbinit.c:
https://review.coreboot.org/c/coreboot/+/84229/comment/7ee00b07_0c17a665?usp... :
PS3, Line 119: int bus, int dev, int fun
Why can't it take a `pcidev_t` ?
https://review.coreboot.org/c/coreboot/+/84229/comment/1fe36e4c_3578883a?usp... :
PS3, Line 130: (did == 0x0000) || (did == 0xffff)) {
It should fit in one line.
https://review.coreboot.org/c/coreboot/+/84229/comment/d5f3689c_a8929ee3?usp... :
PS3, Line 147: if ( is_valid_pci_dev(bus, dev, 0) == false)
The implementation is other parts of the lib is as follow:
```
if (val == 0xffffffff || val == 0x00000000 ||
val == 0x0000ffff || val == 0xffff0000)
```
Could we use this instead ? Could we even make a shared function for it ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I772c4199c7a6c13a25590a36f1bfee17c1a44daf
Gerrit-Change-Number: 84229
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 16:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No