Change in ...coreboot[master]: src/arch: Upgrading SMBIOS to latest version 3.2.

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Francois Toguo Fotso (Code Review)

5 Mar 2019 5 Mar '19

7:56 a.m.

Francois Toguo Fotso has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31725

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

src/arch: Upgrading SMBIOS to latest version 3.2.

"This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2" BUG=NONE TEST=Boot to OS

Signed-off-by: Francois Toguo francois.toguo.fotso@intel.com Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 29 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31725/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index fdf8ca1..7d3cfae 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -560,7 +560,13 @@ t->processor_version = smbios_processor_name(t->eos); t->processor_family = (res.eax > 0) ? 0x0c : 0x6; t->processor_type = 3; /* System Processor */ - t->core_count = (res.ebx >> 16) & 0xff; + if (((res.ebx >> 16) & 0xffff) > 255) { + t->core_count = 0xff; + t->core_count2 = (res.ebx >> 16) & 0xffff; + } else { + t->core_count = (res.ebx >> 16) & 0xff; + t->core_count2 = (res.ebx >> 16) & 0x00ff; + } t->l1_cache_handle = 0xffff; t->l2_cache_handle = 0xffff; t->l3_cache_handle = 0xffff; diff --git a/src/include/smbios.h b/src/include/smbios.h index c046b1a..4937dd6 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -298,6 +298,8 @@ u8 location_in_chassis; u16 chassis_handle; u8 board_type; + u8 num_cont_obj_handles; + u16 cont_obj_hanles[256]; u8 eos[2]; } __packed;

@@ -389,6 +391,9 @@ u8 thread_count; u16 processor_characteristics; u16 processor_family2; + u16 core_count2; + u16 core_enabled2; + u16 thread_count2; u8 eos[2]; } __packed;

@@ -400,6 +405,11 @@ u8 eos[2]; } __packed;

+typedef struct { + u8 type; + u8 format_descriptor; +} log_type_descriptor; + struct smbios_type15 { u8 type; u8 length; @@ -414,6 +424,7 @@ u8 header_format; u8 log_type_descriptors; u8 log_type_descriptor_length; + log_type_descriptor descriptor[0]; u8 eos[2]; } __packed;

@@ -470,6 +481,17 @@ u16 minimum_voltage; u16 maximum_voltage; u16 configured_voltage; + u8 memory_technology; + u16 operating_mode_capability; + u8 fw_version; + u16 manufacturer_id; + u16 product_id; + u16 sub_ctrl_manufacturer_id; + u16 sub_ctrl_product_id; + u64 non_volatile_size; + u64 volatile_size; + u64 cache_size; + u64 logical_size; u8 eos[2]; } __packed;

Attachments:

attachment.htm (text/html — 6.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

5 Mar 5 Mar

7:56 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31725/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/31725/1/src/arch/x86/smbios.c@563 PS1, Line 563: if (((res.ebx >> 16) & 0xffff) > 255) { suspect code indent for conditional statements (8, 10)

https://review.coreboot.org/#/c/31725/1/src/arch/x86/smbios.c@566 PS1, Line 566: } else { suspect code indent for conditional statements (8, 10)

Francois Toguo Fotso (Code Review)

8 a.m.

Francois Toguo Fotso has uploaded a new patch set (#2) to the change originally created by Francois Toguo Fotso. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

src/arch: Upgrading SMBIOS to latest version 3.2.

"This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2" BUG=NONE TEST=Boot to OS

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31725/2

HAOUAS Elyes (Code Review)

8:35 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-Comment-Date: Tue, 05 Mar 2019 11:35:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

9:16 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c@564 PS2, Line 564: t->core_count = 0xff; that's seems wrong. the bits 31:24 contain the APIC ID.

CPUID EAX=4 and ECX=0 should be used to detect cores per package.

https://review.coreboot.org/#/c/31725/2/src/include/smbios.h File src/include/smbios.h:

https://review.coreboot.org/#/c/31725/2/src/include/smbios.h@395 PS2, Line 395: u16 core_enabled2; not sure how to detect those. Set to core_count2?

https://review.coreboot.org/#/c/31725/2/src/include/smbios.h@396 PS2, Line 396: u16 thread_count2; CPUID EAX=4 and ECX=0 should be used to detect threads per package.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Tue, 05 Mar 2019 12:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:23 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@7 PS2, Line 7: Upgrading 1. Please use imperative mood: Upgrade … 2. Please remove the dot/period at the end of the commit message summary

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@9 PS2, Line 9: "This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2" Please remove the quotes, and add a blank line below.

Additionally, where is the first patch?

It’d be great, if you could summarize the changes in the new version.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 2 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 05 Mar 2019 12:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Francois Toguo Fotso (Code Review)

6 Mar 6 Mar

2:37 a.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

Francois Toguo Fotso has uploaded a new patch set (#3) to the change originally created by Francois Toguo Fotso. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

src/arch: An upgrade of SMBIOS to latest version 3.2

This is the second of 2 patches upgrading the SMBIOS interface to the latest 3.2 First patch is in mosys. Newer required fields are added to various types definitions

BUG=NONE TEST=Boot to OS

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31725/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 3 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

8 Mar 8 Mar

9:38 p.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

Patch Set 3:

(3 comments)

Hello Francois,

this patch collided with another one that was already discussed a little more: CB:31420. Please read the com- ments there, as they mostly also apply here.

In short, please don't add fields without giving them a reasonable value.

https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/31725/2/src/arch/x86/smbios.c@564 PS2, Line 564: t->core_count = 0xff;

...

that's seems wrong. the bits 31:24 contain the APIC ID. […]

Both cpuid leafs return only the maximum number of IDs. The original code was acceptable (using maximum number of IDs as core count), you could just copy that value to `core_count2`.

A correct solution would be platform specific. That could also provide more details like the number of active cores.

https://review.coreboot.org/#/c/31725/3/src/include/smbios.h File src/include/smbios.h:

https://review.coreboot.org/#/c/31725/3/src/include/smbios.h@427 PS3, Line 427: log_type_descriptor descriptor[0]; This declaration doesn't seem useful as any dereference would collide with `eos` below.

https://review.coreboot.org/#/c/31725/3/src/include/smbios.h@491 PS3, Line 491: u64 non_volatile_size; : u64 volatile_size; : u64 cache_size; : u64 logical_size; These should be set to -1 if unknown.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 3 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 08 Mar 2019 12:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Francois Toguo Fotso (Code Review)

13 Mar 13 Mar

5:56 a.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

Hello Aaron Durbin, HAOUAS Elyes, build bot (Jenkins), Lijian Zhao, Nico Huber, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31725

to look at the new patch set (#4).

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

src/arch: An upgrade of SMBIOS to latest version 3.2

This is the second of 2 patches upgrading the SMBIOS interface to the latest 3.2 First patch is in mosys. Newer required fields are added to various types definitions

BUG=NONE TEST=Boot to OS

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31725/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

5:56 a.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/31725/4/src/arch/x86/smbios.c File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/31725/4/src/arch/x86/smbios.c@563 PS4, Line 563: if (((res.ebx >> 16) & 0xffff) > 255) { suspect code indent for conditional statements (8, 10)

https://review.coreboot.org/#/c/31725/4/src/arch/x86/smbios.c@566 PS4, Line 566: } else { suspect code indent for conditional statements (8, 10)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 12 Mar 2019 20:56:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Francois Toguo Fotso (Code Review)

6:41 a.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

Patch Set 4:

(2 comments)

Abandonned: please see the following patch with all finding implemented: https://review.coreboot.org/c/coreboot/+/31863/4

Please note core count are being computed with leaf 0xb per page 768 of https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32...

Result verified with a GLK platform. Those new APIs can be overwriten as needed per platform.

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@7 PS2, Line 7: Upgrading

...

Please use imperative mood: Upgrade … […]

Done

https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@9 PS2, Line 9: "This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2"

...

Please remove the quotes, and add a blank line below. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 12 Mar 2019 21:41:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Francois Toguo Fotso (Code Review)

14 Mar 14 Mar

9:16 a.m.

New subject: Change in ...coreboot[master]: src/arch: An upgrade of SMBIOS to latest version 3.2

Francois Toguo Fotso has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31725 )

Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................

Abandoned

follow up patch: https://review.coreboot.org/c/coreboot/+/31863

-- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 4 Gerrit-Owner: Francois Toguo Fotso francois.toguo.fotso@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Francois Toguo Fotso francois.toguo.fotso@intel.corp-partner.google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

2033

days inactive

2043

days old

coreboot-gerrit@coreboot.org

11 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Francois Toguo Fotso (Code Review)
HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)