Change in coreboot[master]: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series

Add all Intel WIFI 6 series PCI ids into device/pci_ids.h file.

TEST=HrP Wi-Fi module is getting detected during PCI enumeration.

Change-Id: Id5452c5c02b58e84d8e5768653b18c9d1246c1bb
Signed-off-by: Subrata Banik 
---
M src/drivers/intel/wifi/wifi.c
M src/include/device/pci_ids.h
2 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/40224/1

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index af7407d..c3e551a 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -145,6 +145,14 @@
    PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI,
+	PCI_DEVICE_ID_HrP_6SERIES_WIFI,
+	/* Cyclone Peak */
+	PCI_DEVICE_ID_CyP_6SERIES_WIFI,
+	/* Typhoon Peak */
+	PCI_DEVICE_ID_TyP_6SERIES_WIFI,
+	/* Garfiled Peak */
+	PCI_DEVICE_ID_GrP_6SERIES_1_WIFI,
+	PCI_DEVICE_ID_GrP_6SERIES_2_WIFI,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 13004db..4898a91 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3676,6 +3676,11 @@
 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI	0xa0f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI	0x02f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI	0x06f0
+#define PCI_DEVICE_ID_CyP_6SERIES_WIFI		0x2723
+#define PCI_DEVICE_ID_HrP_6SERIES_WIFI		0x2720
+#define PCI_DEVICE_ID_TyP_6SERIES_WIFI		0x2725
+#define PCI_DEVICE_ID_GrP_6SERIES_1_WIFI	0x51f0
+#define PCI_DEVICE_ID_GrP_6SERIES_2_WIFI	0x7af0

#define PCI_VENDOR_ID_COMPUTONE		0x8e0e
 #define PCI_DEVICE_ID_COMPUTONE_IP2EX	0x0291

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG@9 
PS1, Line 9: into
to

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG@11 
PS1, Line 11: HrP
What is HrP?

[Subrata Banik (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Duncan Laurie, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40224

to look at the new patch set (#2).

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series

Add all Intel WIFI 6 series PCI ids to device/pci_ids.h file.

TEST=Harrison Peak (HrP) Wi-Fi module is getting detected during PCI enumeration.

Change-Id: Id5452c5c02b58e84d8e5768653b18c9d1246c1bb
Signed-off-by: Subrata Banik 
---
M src/drivers/intel/wifi/wifi.c
M src/include/device/pci_ids.h
2 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/40224/2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG@9 
PS1, Line 9: into
> to

Ack

https://review.coreboot.org/c/coreboot/+/40224/1//COMMIT_MSG@11 
PS1, Line 11: HrP
> What is HrP?

Ack

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

Patch Set 2: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series

Add all Intel WIFI 6 series PCI ids to device/pci_ids.h file.

TEST=Harrison Peak (HrP) Wi-Fi module is getting detected during PCI enumeration.

Change-Id: Id5452c5c02b58e84d8e5768653b18c9d1246c1bb
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40224
Reviewed-by: Duncan Laurie 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/wifi/wifi.c
M src/include/device/pci_ids.h
2 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index af7407d..c3e551a 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -145,6 +145,14 @@
    PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI,
+	PCI_DEVICE_ID_HrP_6SERIES_WIFI,
+	/* Cyclone Peak */
+	PCI_DEVICE_ID_CyP_6SERIES_WIFI,
+	/* Typhoon Peak */
+	PCI_DEVICE_ID_TyP_6SERIES_WIFI,
+	/* Garfiled Peak */
+	PCI_DEVICE_ID_GrP_6SERIES_1_WIFI,
+	PCI_DEVICE_ID_GrP_6SERIES_2_WIFI,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 13004db..4898a91 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3676,6 +3676,11 @@
 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI	0xa0f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI	0x02f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI	0x06f0
+#define PCI_DEVICE_ID_CyP_6SERIES_WIFI		0x2723
+#define PCI_DEVICE_ID_HrP_6SERIES_WIFI		0x2720
+#define PCI_DEVICE_ID_TyP_6SERIES_WIFI		0x2725
+#define PCI_DEVICE_ID_GrP_6SERIES_1_WIFI	0x51f0
+#define PCI_DEVICE_ID_GrP_6SERIES_2_WIFI	0x7af0

#define PCI_VENDOR_ID_COMPUTONE		0x8e0e
 #define PCI_DEVICE_ID_COMPUTONE_IP2EX	0x0291

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40224 )

Change subject: drivers/intel/wifi: Add support for Intel Wi-Fi 6 Series
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2170
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2169
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2168

Please note: This test is under development and might not be accurate at all!