Attention is currently required from: Angel Pons, Kyösti Mälkki, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 5:
(9 comments)
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/94cec7b9_66eb4776 PS5, Line 72: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/daf7722a_aacefa33 PS5, Line 175: while (i--) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/bab68a96_aba16c62 PS5, Line 696: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/4b97290a_047d46c7 PS5, Line 1187: if (!(dimm_mask & (1 << i))) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/a78d8255_a4110df1 PS5, Line 1204: if (value != ERROR_SCHEME_ECC) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/902c05a4_083057f8 PS5, Line 1274: if (sdram_width.side1 == 4) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/a77ceee4_bc894fff PS5, Line 1278: if (sdram_width.side2 == 4) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/aba55708_2af3b029 PS5, Line 55: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052): https://review.coreboot.org/c/coreboot/+/69339/comment/b0d8b2ae_0de53bdf PS5, Line 58: if (new_disable_mask != cur_disable_mask) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)