HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46011 )
Change subject: mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax
Change-Id: I305561625d973093645236c77ef13a96ab780f94 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x60/acpi/dock.asl M src/mainboard/lenovo/x60/acpi/gpe.asl M src/mainboard/lenovo/x60/acpi/platform.asl 3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/46011/1
diff --git a/src/mainboard/lenovo/x60/acpi/dock.asl b/src/mainboard/lenovo/x60/acpi/dock.asl index 26f555f..5fd6978 100644 --- a/src/mainboard/lenovo/x60/acpi/dock.asl +++ b/src/mainboard/lenovo/x60/acpi/dock.asl @@ -27,7 +27,7 @@ TRAP(SMI_DOCK_DISCONNECT) }
- Xor(Arg0, DSTA, Local0) + Local0 = Arg0 ^ DSTA Return (Local0) }
diff --git a/src/mainboard/lenovo/x60/acpi/gpe.asl b/src/mainboard/lenovo/x60/acpi/gpe.asl index 62e7b37..9984636 100644 --- a/src/mainboard/lenovo/x60/acpi/gpe.asl +++ b/src/mainboard/lenovo/x60/acpi/gpe.asl @@ -5,8 +5,8 @@ Method(_L18, 0, NotSerialized) { /* Read EC register to clear wake status */ - Store(_SB.PCI0.LPCB.EC.WAKE, Local0) + Local0 = _SB.PCI0.LPCB.EC.WAKE /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ } } diff --git a/src/mainboard/lenovo/x60/acpi/platform.asl b/src/mainboard/lenovo/x60/acpi/platform.asl index c9551b5..ca52e5d 100644 --- a/src/mainboard/lenovo/x60/acpi/platform.asl +++ b/src/mainboard/lenovo/x60/acpi/platform.asl @@ -24,12 +24,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
@@ -60,7 +60,7 @@ * running: Windows XP SP1 needs to have C-State coordination * enabled in SMM. */ - If (LAnd(LEqual(OSYS, 2001), MPEN)) { + If ((OSYS == 2001) && MPEN) { // TRAP(61) // TODO }
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46011
to look at the new patch set (#3).
Change subject: mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax
Change-Id: I305561625d973093645236c77ef13a96ab780f94 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x60/acpi/dock.asl M src/mainboard/lenovo/x60/acpi/gpe.asl M src/mainboard/lenovo/x60/acpi/platform.asl 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/46011/3
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46011
to look at the new patch set (#4).
Change subject: mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax
Generated 'build/dsdt.dsl' are identical.
Change-Id: I305561625d973093645236c77ef13a96ab780f94 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x60/acpi/dock.asl M src/mainboard/lenovo/x60/acpi/gpe.asl M src/mainboard/lenovo/x60/acpi/platform.asl 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/46011/4
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46011 )
Change subject: mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax ......................................................................
Patch Set 4: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46011 )
Change subject: mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/lenovo/x60: Convert *.asl to ASL 2.0 syntax
Generated 'build/dsdt.dsl' are identical.
Change-Id: I305561625d973093645236c77ef13a96ab780f94 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46011 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/lenovo/x60/acpi/dock.asl M src/mainboard/lenovo/x60/acpi/gpe.asl M src/mainboard/lenovo/x60/acpi/platform.asl 3 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x60/acpi/dock.asl b/src/mainboard/lenovo/x60/acpi/dock.asl index 26f555f..5fd6978 100644 --- a/src/mainboard/lenovo/x60/acpi/dock.asl +++ b/src/mainboard/lenovo/x60/acpi/dock.asl @@ -27,7 +27,7 @@ TRAP(SMI_DOCK_DISCONNECT) }
- Xor(Arg0, DSTA, Local0) + Local0 = Arg0 ^ DSTA Return (Local0) }
diff --git a/src/mainboard/lenovo/x60/acpi/gpe.asl b/src/mainboard/lenovo/x60/acpi/gpe.asl index 62e7b37..9984636 100644 --- a/src/mainboard/lenovo/x60/acpi/gpe.asl +++ b/src/mainboard/lenovo/x60/acpi/gpe.asl @@ -5,8 +5,8 @@ Method(_L18, 0, NotSerialized) { /* Read EC register to clear wake status */ - Store(_SB.PCI0.LPCB.EC.WAKE, Local0) + Local0 = _SB.PCI0.LPCB.EC.WAKE /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ } } diff --git a/src/mainboard/lenovo/x60/acpi/platform.asl b/src/mainboard/lenovo/x60/acpi/platform.asl index 2e3bfc0..50da033 100644 --- a/src/mainboard/lenovo/x60/acpi/platform.asl +++ b/src/mainboard/lenovo/x60/acpi/platform.asl @@ -24,12 +24,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)