Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74099/comment/01e79c5d_27ddf471
PS5, Line 19:
: config CHROMEOS
: select EC_GOOGLE_CHROMEEC_SWITCHES
Are we targeting non-chromeos builds? IMO we should be using verstage after bootblock for bringup in […]
We're not trying to get a non-chromeos build working, it's just a vboot config item and it will end up being moved later. I'm not sure I follow the verstage after bootblock comment. If you look at line 50, that's how we hadd things setup for Skyrim bringup too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e
Gerrit-Change-Number: 74099
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 22:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment