Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Julian Schroeder, Felix Held. Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: src/soc/amd/common/fsp: check FSP binary version. ......................................................................
Patch Set 1:
(4 comments)
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/58869/comment/98d31474_02ab6180 PS1, Line 13: //jsd
?
debug marker. forgot to take it out.
https://review.coreboot.org/c/coreboot/+/58869/comment/1a83ea9d_cd6b6e09 PS1, Line 34: #define FSP_INFO_HEADER_OFF 0x94
this is a redefinition of FSP_HDR_OFFSET
same offset. different header.
https://review.coreboot.org/c/coreboot/+/58869/comment/ef38fa43_50c879f0 PS1, Line 35: fsp_info_header
this looks like a redefinition of fsp_header right above
this is an fsp_info_header. Quite different from a fsp_header.
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/58869/comment/d081f122_a7a35855 PS1, Line 80: struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF);
not sure why this is needed. […]
where would I get the fsp binary version from? I need the fsp_info_header to get the AMD image revision major, minor, revision, build number to implement the feature you want. the current soc_validate_fspm_header currently only checks the file size, not major, minor.
-
Name of user not set (Code Review)