Attention is currently required from: Arthur Heymans, Christian Walter, Eric Lai, Felix Singer, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Chu, Ziang Wang.
Hello Arthur Heymans, Christian Walter, Eric Lai, Felix Singer, Johnny Lin, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75740?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai
Change subject: soc/intel/xeon_sp/spr: Add weak method to get memory capability
......................................................................
soc/intel/xeon_sp/spr: Add weak method to get memory capability
Memory capacity could be 4TB or 6TB on different SPR SKUs, instead of
setting it statically at SoC level, it is better using a weak function
that can be overrode by mainboard.
Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767
Signed-off-by: Ziang Wang ziang.wang@intel.com
---
M src/soc/intel/xeon_sp/spr/include/soc/ddr.h
M src/soc/intel/xeon_sp/spr/romstage.c
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/75740/10
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767
Gerrit-Change-Number: 75740
Gerrit-PatchSet: 10
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-MessageType: newpatchset