[XS] Change in coreboot[master]: soc/amd/block/ivrs: Add NULL check for IVRS - coreboot-gerrit

14 Jun 2023


      Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Naresh Solanki, Raul Rangel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75506?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/amd/block/ivrs: Add NULL check for IVRS
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/acpi/ivrs.c:
https://review.coreboot.org/c/coreboot/+/75506/comment/b459b03f_28b32f46 :
PS2, Line 339: 		return (unsigned long)ivrs;
Why not just `return 0`?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75506?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb0ea3bcaa3512a93500588ad4f11046edee61f
Gerrit-Change-Number: 75506
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki naresh.solanki@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Naresh Solanki naresh.solanki@9elements.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 14 Jun 2023 09:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment