Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35169 )
Change subject: payloads/external/LinuxBoot: Add curl flag ......................................................................
payloads/external/LinuxBoot: Add curl flag
add --show-error curl flag to see the error message, even on silent mode.
Signed-off-by: Marcello Sylvester Bauer sylvblck@sylv.io Change-Id: I4ad40718caab60413ffe9c1503a9870cb875dd43 --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/35169/1
diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk index e32ad1e..b7b3a0d 100644 --- a/payloads/external/LinuxBoot/targets/linux.mk +++ b/payloads/external/LinuxBoot/targets/linux.mk @@ -33,7 +33,7 @@ ifeq ($(CONFIG_LINUXBOOT_KERNEL_CUSTOM),y) kernel_version:=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION) else - kernel_version:=$(shell curl -s -k https://www.kernel.org/feeds/kdist.xml | \ + kernel_version:=$(shell curl -sS -k https://www.kernel.org/feeds/kdist.xml | \ sed -n -e 's@.*<guid isPermaLink="false">(.*)</guid>.*@\1@p' | \ awk -F ',' '/$(TAG-y)/{ print $$3 }' | \ head -n 1) @@ -67,7 +67,7 @@ if [[ ! -f $(tarball_dir)/$(kernel_tarball).xz && ! -f $(tarball_dir)/$(kernel_tarball).xz ]]; then \ echo " WWW $(kernel_tarball).xz"; \ cd $(tarball_dir); \ - curl -OLs "$(kernel_mirror_path)/$(kernel_tarball).xz"; \ + curl -OLSs "$(kernel_mirror_path)/$(kernel_tarball).xz"; \ cd $(pwd); \ fi endif
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35169 )
Change subject: payloads/external/LinuxBoot: Add curl flag ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35169 )
Change subject: payloads/external/LinuxBoot: Add curl flag ......................................................................
payloads/external/LinuxBoot: Add curl flag
add --show-error curl flag to see the error message, even on silent mode.
Signed-off-by: Marcello Sylvester Bauer sylvblck@sylv.io Change-Id: I4ad40718caab60413ffe9c1503a9870cb875dd43 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35169 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk index e32ad1e..b7b3a0d 100644 --- a/payloads/external/LinuxBoot/targets/linux.mk +++ b/payloads/external/LinuxBoot/targets/linux.mk @@ -33,7 +33,7 @@ ifeq ($(CONFIG_LINUXBOOT_KERNEL_CUSTOM),y) kernel_version:=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION) else - kernel_version:=$(shell curl -s -k https://www.kernel.org/feeds/kdist.xml | \ + kernel_version:=$(shell curl -sS -k https://www.kernel.org/feeds/kdist.xml | \ sed -n -e 's@.*<guid isPermaLink="false">(.*)</guid>.*@\1@p' | \ awk -F ',' '/$(TAG-y)/{ print $$3 }' | \ head -n 1) @@ -67,7 +67,7 @@ if [[ ! -f $(tarball_dir)/$(kernel_tarball).xz && ! -f $(tarball_dir)/$(kernel_tarball).xz ]]; then \ echo " WWW $(kernel_tarball).xz"; \ cd $(tarball_dir); \ - curl -OLs "$(kernel_mirror_path)/$(kernel_tarball).xz"; \ + curl -OLSs "$(kernel_mirror_path)/$(kernel_tarball).xz"; \ cd $(pwd); \ fi endif
-
Marcello Sylvester Bauer (Code Review) -
Patrick Georgi (Code Review)