Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76163?usp=email )
Change subject: amdfwtool: Allow bios table source addresses to select base ......................................................................
amdfwtool: Allow bios table source addresses to select base
Addresses passed to register_bios_fw_addr src_str already have a '0x' prefix for hex values. Forcing the base to 16 causes improper conversion when decimal addresses are passed in. Setting the 'base' parameter to '0' lets strtoull automatically select the correct base from the prefix.
TEST=timeless builds identical for chausie and majolica
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: I45474600048a33ad186ba4d1baed7b5891ffdefe --- M util/amdfwtool/amdfwtool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/76163/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 1b2b005..4164c19 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1715,7 +1715,7 @@ continue;
if (src_str) - amd_bios_table[i].src = strtoull(src_str, NULL, 16); + amd_bios_table[i].src = strtoull(src_str, NULL, 0); if (dst_str) amd_bios_table[i].dest = strtoull(dst_str, NULL, 16); if (size_str)