Change in coreboot[master]: mb/*/Kconfig: Annotate closing #endif with corresponding condition
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing #endif with corresponding condition ......................................................................
mb/*/Kconfig: Annotate closing #endif with corresponding condition
It’s common to annotate the closing #endif, so do it for these four files.
Change-Id: Ia5d071e1f544c9dea5af9c6bc3c605d9a0c5c0f5 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/clevo/Kconfig M src/mainboard/razer/Kconfig M src/mainboard/system76/Kconfig M src/mainboard/up/Kconfig 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/47477/1
diff --git a/src/mainboard/clevo/Kconfig b/src/mainboard/clevo/Kconfig index d5ae6c1..96a5cbf 100644 --- a/src/mainboard/clevo/Kconfig +++ b/src/mainboard/clevo/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "Clevo"
-endif +endif #VENDOR_CLEVO diff --git a/src/mainboard/razer/Kconfig b/src/mainboard/razer/Kconfig index 9d96888..9f9c6fd 100644 --- a/src/mainboard/razer/Kconfig +++ b/src/mainboard/razer/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "RAZER"
-endif +endif # VENDOR_RAZER diff --git a/src/mainboard/system76/Kconfig b/src/mainboard/system76/Kconfig index 785d117..296f701 100644 --- a/src/mainboard/system76/Kconfig +++ b/src/mainboard/system76/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "System76"
-endif +endif # VENDOR_SYSTEM76 diff --git a/src/mainboard/up/Kconfig b/src/mainboard/up/Kconfig index aa8eda6..fdb3e71 100644 --- a/src/mainboard/up/Kconfig +++ b/src/mainboard/up/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "UP"
-endif +endif # VENDOR_UP
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing #endif with corresponding condition ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47477/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47477/1//COMMIT_MSG@7 PS1, Line 7: # Kconfig isn't preprocessor, `#endif` would be a comment
https://review.coreboot.org/c/coreboot/+/47477/1/src/mainboard/clevo/Kconfig File src/mainboard/clevo/Kconfig:
https://review.coreboot.org/c/coreboot/+/47477/1/src/mainboard/clevo/Kconfig... PS1, Line 15: # Why no space?
Hello build bot (Jenkins), Jeremy Soller, Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47477
to look at the new patch set (#2).
Change subject: mb/*/Kconfig: Annotate closing endif with corresponding condition ......................................................................
mb/*/Kconfig: Annotate closing endif with corresponding condition
It’s common to annotate the closing endif, so do it for these four files.
Change-Id: Ia5d071e1f544c9dea5af9c6bc3c605d9a0c5c0f5 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/clevo/Kconfig M src/mainboard/razer/Kconfig M src/mainboard/system76/Kconfig M src/mainboard/up/Kconfig 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/47477/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing endif with corresponding condition ......................................................................
Patch Set 2:
(2 comments)
Thank you for spotting the two things.
https://review.coreboot.org/c/coreboot/+/47477/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47477/1//COMMIT_MSG@7 PS1, Line 7: #
Kconfig isn't preprocessor, `#endif` would be a comment
Done
https://review.coreboot.org/c/coreboot/+/47477/1/src/mainboard/clevo/Kconfig File src/mainboard/clevo/Kconfig:
https://review.coreboot.org/c/coreboot/+/47477/1/src/mainboard/clevo/Kconfig... PS1, Line 15: #
Why no space?
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing endif with corresponding condition ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing endif with corresponding condition ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47477 )
Change subject: mb/*/Kconfig: Annotate closing endif with corresponding condition ......................................................................
mb/*/Kconfig: Annotate closing endif with corresponding condition
It’s common to annotate the closing endif, so do it for these four files.
Change-Id: Ia5d071e1f544c9dea5af9c6bc3c605d9a0c5c0f5 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47477 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/clevo/Kconfig M src/mainboard/razer/Kconfig M src/mainboard/system76/Kconfig M src/mainboard/up/Kconfig 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/Kconfig b/src/mainboard/clevo/Kconfig index d5ae6c1..1c95d2b 100644 --- a/src/mainboard/clevo/Kconfig +++ b/src/mainboard/clevo/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "Clevo"
-endif +endif # VENDOR_CLEVO diff --git a/src/mainboard/razer/Kconfig b/src/mainboard/razer/Kconfig index 9d96888..9f9c6fd 100644 --- a/src/mainboard/razer/Kconfig +++ b/src/mainboard/razer/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "RAZER"
-endif +endif # VENDOR_RAZER diff --git a/src/mainboard/system76/Kconfig b/src/mainboard/system76/Kconfig index 785d117..296f701 100644 --- a/src/mainboard/system76/Kconfig +++ b/src/mainboard/system76/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "System76"
-endif +endif # VENDOR_SYSTEM76 diff --git a/src/mainboard/up/Kconfig b/src/mainboard/up/Kconfig index aa8eda6..fdb3e71 100644 --- a/src/mainboard/up/Kconfig +++ b/src/mainboard/up/Kconfig @@ -12,4 +12,4 @@ config MAINBOARD_VENDOR default "UP"
-endif +endif # VENDOR_UP
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Paul Menzel (Code Review)