Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )
Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/#/c/18557/14/src/soc/intel/common/block/include/...
File src/soc/intel/common/block/include/intelblocks/fast_spi.h:
Line 157
Are all of these functions necessary to be exposed?
Sorry Aaron, I think I have not understood this comment properly.
If we call these APIs from user, then these function declarations in this file need to exposed, right? And, we will have to include this header file.
--
To view, visit
https://review.coreboot.org/18557
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 15
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes