Attention is currently required from: Nico Huber, Paul Fagerburg, Julius Werner, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58242 )
Change subject: libpayload: Add unit-tests framework and first test case
......................................................................
Patch Set 5:
(2 comments)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/58242/comment/d4802c0b_62e4bfb5
PS4, Line 120: # 3. when make distclean is run
Please update the comments.
Done. Thanks
I also fixed comments on line 305
File payloads/libpayload/tests/Makefile.inc:
PS4:
Looks like most of the content is copied from coreboot/tests/Makefile.inc.
Yes, it does not differ much. It is easier to just copy this framework, than to configure coreboot/tests/Makefile.inc to run tests from both the coreboot, and the libpayload. Libpayload is a separate project inside coreboot repo after all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa94ee4dcdc3f74af830113813df0e8fb0b31e4f
Gerrit-Change-Number: 58242
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 10:58:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment