Change in coreboot[master]: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

12 Jun 2020 12 Jun '20

7:12 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig

This change adds FSP_M_FILE and FSP_S_FILE selection to Kconfig dependent on ADD_FSP_BINARIES. This relieves each variant from setting this config separately in config.${VARIANT} in chromiumos-overlay in chromium tree.

Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42337/1

diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index ab24213..442d569 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -136,4 +136,14 @@ help Which board version did FW_CONFIG become valid in CBI.

+config FSP_M_FILE + string + depends on ADD_FSP_BINARIES + default "3rdparty/amd_blobs/picasso/PICASSO_M.fd" + +config FSP_S_FILE + string + depends on ADD_FSP_BINARIES + default "3rdparty/amd_blobs/picasso/PICASSO_S.fd" + endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Nico Huber (Code Review)

13 Jun 13 Jun

3:51 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

Why not do it at the soc/ level? The paths don't look mainboard specific.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 13 Jun 2020 10:51:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

7:03 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

...

Patch Set 1:

Why not do it at the soc/ level? The paths don't look mainboard specific.

+1, the goal is to have a single FSP binary for all of picasso.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 13 Jun 2020 14:03:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

8:56 a.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

Oh, yeah, you can't submit this until the FSP binaries have been pushed to amd_blobs. That's why we have it in the .configs

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 13 Jun 2020 15:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

8:59 a.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1: Code-Review-1

this should be at soc level not at board level

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sat, 13 Jun 2020 15:59:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

15 Jun 15 Jun

6:16 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

...

Patch Set 1:

Oh, yeah, you can't submit this until the FSP binaries have been pushed to amd_blobs. That's why we have it in the .configs

Humm... looks like jenkins is running abuild with -B option which turns ADD_FSP_BINARIES on by default. It feels like there should be an option to say that a platform does not want to add FSP binaries. Anyways, I don't really have cycles to dig into this right now. We can wait until FSP blobs are added to 3rdparty/amd_blobs and then add FSP_M_FILE and FSP_S_FILE to soc/amd/picasso/Kconfig.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 16 Jun 2020 01:16:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:16 p.m.

Furquan Shaikh has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Abandoned

Need to wait until FSP blobs for Picasso are added to amd_blobs.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: abandon

Nico Huber (Code Review)

21 Jun 21 Jun

6:31 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

...

...
Oh, yeah, you can't submit this until the FSP binaries have been pushed to amd_blobs. That's why we have it in the .configs

Humm... looks like jenkins is running abuild with -B option which turns ADD_FSP_BINARIES on by default.

That's probably unintentional. ADD_FSP_BINARIES is implied by the USE_FSP_REPO option now, so there is no need to force it in this case. And AFAIK, there is no other public place for Intel FSP binaries.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Sun, 21 Jun 2020 13:31:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

22 Jun 22 Jun

10:29 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42337 )

Change subject: mb/google/zork: Add FSP_M_FILE and FSP_S_FILE selection to Kconfig ......................................................................

Patch Set 1:

...

Patch Set 1:

...
...
Oh, yeah, you can't submit this until the FSP binaries have been pushed to amd_blobs. That's why we have it in the .configs

Humm... looks like jenkins is running abuild with -B option which turns ADD_FSP_BINARIES on by default.

That's probably unintentional. ADD_FSP_BINARIES is implied by the USE_FSP_REPO option now, so there is no need to force it in this case. And AFAIK, there is no other public place for Intel FSP binaries.

Yeah, I think the abuild configs need to be revisited.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1db5e1a53afb9eb2d2bf200f8e806160014e06c Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 23 Jun 2020 05:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1611

days inactive

1621

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Felix Held (Code Review)
Furquan Shaikh (Code Review)
Nico Huber (Code Review)
Raul Rangel (Code Review)