Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42847 )
Change subject: mb/intel,samsung: Drop unused static gnvs_ ......................................................................
mb/intel,samsung: Drop unused static gnvs_
Change-Id: I920e5e6a3fa92ede4a0b0388962b55208a7dee48 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c 3 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/42847/1
diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c index 36d0d66..dd98883 100644 --- a/src/mainboard/intel/emeraldlake2/acpi_tables.c +++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c @@ -8,12 +8,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* Enable USB ports in S3 */ gnvs->s3u0 = 1; gnvs->s3u1 = 1; diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index aafbdb6..c1489eb 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -11,12 +11,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* * Disable 3G in suspend by default. * Provide option to enable for http://crosbug.com/p/7925 diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c index b66e4dd..9793c1c 100644 --- a/src/mainboard/samsung/stumpy/acpi_tables.c +++ b/src/mainboard/samsung/stumpy/acpi_tables.c @@ -8,12 +8,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* Enable Front USB ports in S3 by default */ gnvs->s3u0 = 1; gnvs->s3u1 = 1;
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42847 )
Change subject: mb/intel,samsung: Drop unused static gnvs_ ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42847 )
Change subject: mb/intel,samsung: Drop unused static gnvs_ ......................................................................
mb/intel,samsung: Drop unused static gnvs_
Change-Id: I920e5e6a3fa92ede4a0b0388962b55208a7dee48 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42847 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c 3 files changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c index 36d0d66..dd98883 100644 --- a/src/mainboard/intel/emeraldlake2/acpi_tables.c +++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c @@ -8,12 +8,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* Enable USB ports in S3 */ gnvs->s3u0 = 1; gnvs->s3u1 = 1; diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index aafbdb6..c1489eb 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -11,12 +11,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* * Disable 3G in suspend by default. * Provide option to enable for http://crosbug.com/p/7925 diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c index b66e4dd..9793c1c 100644 --- a/src/mainboard/samsung/stumpy/acpi_tables.c +++ b/src/mainboard/samsung/stumpy/acpi_tables.c @@ -8,12 +8,8 @@
#include "thermal.h"
-static global_nvs_t *gnvs_; - void acpi_create_gnvs(global_nvs_t *gnvs) { - gnvs_ = gnvs; - /* Enable Front USB ports in S3 by default */ gnvs->s3u0 = 1; gnvs->s3u1 = 1;