Attention is currently required from: Jason Glenesk, Raul Rangel, Lee Leahy, Marshall Dawson, Angel Pons, Huang Jin, Andrey Petrov, Patrick Rudolph, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50000 )
Change subject: stage_cache: Add resume_from_stage_cache()
......................................................................
Patch Set 1:
(1 comment)
File src/lib/prog_loaders.c:
https://review.coreboot.org/c/coreboot/+/50000/comment/c071fbd6_ebc56c93
PS1, Line 118: if (resume_from_stage_cache())
Where did the ENV_X86 guard go? Should the comment above be updated?
If we did have !ENV_X86 with HAVE_ACPI_RESUME and !NO_STAGE_CACHE it should be fine to resume from stage cache, right.
I am not sure where the work Julius does with CBFS per-file hashing leads us. Will these somehow converge such that verification step already leaves the copy we want inside the stage cache and the test of acpi_is_wakeup_s3() would be dropped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I936f07bed6fc82f46118d217f1fd233e2e041405
Gerrit-Change-Number: 50000
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Huang Jin
huang.jin@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Jan 2021 19:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment