[S] Change in coreboot[main]: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, V Sowmya.

Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email )

Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
......................................................................

Patch Set 7:

(1 comment)

File src/mainboard/google/brya/variants/nivviks/fw_config.c:

https://review.coreboot.org/c/coreboot/+/83077/comment/e7adedbb_d97fd7f8?usp... :
PS6, Line 103: PAD_CFG_GPO
> Another case, i can think of now is , when there is any update for any wifi  firmware, don't they prefer to reset it completely?

if wifi fw update required to reset the controller then there should be power sequencing code existed in BIOS/ACPI because none of the kernel driver actually aware how to reset the controller w/o end details about platform.

Better you check with kernel/driver folks, my recommendation is simple, lock the GPO unless there is a valid driver usage. There is no point of argue unless there are some data that says either we need or we don't need to configure those PINs being independent of AP FW.