Attention is currently required from: Derek Huang, Henry Sun, Tarun Tuli, Yunlong Jia.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76104?usp=email )
Change subject: mb/google/nissa: Setup driver for gothrax
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76104/comment/5ac05791_d9b5daa2 :
PS1, Line 7: Setup
The verb is spelled with a space: Set up.
https://review.coreboot.org/c/coreboot/+/76104/comment/d463d329_2736c9fb :
PS1, Line 9: Setup
Ditto: The verb is spelled with a space: Set up.
https://review.coreboot.org/c/coreboot/+/76104/comment/9bb4ca6f_d03c65b4 :
PS1, Line 11:
What source did you use for your changes? Schematics?
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/76104/comment/fdb66490_b4230782 :
PS1, Line 389: select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER
Why select this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1203ca13bd55b8ab96ce5d323a36ffde06860fa9
Gerrit-Change-Number: 76104
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 09:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment