Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56339/comment/48a1b78d_7cb2efc7 PS2, Line 7: asrock/e3c246d4i: Add board Maybe:
mb/asrock/e3c246d4i: Add Intel Coffee Lake board
https://review.coreboot.org/c/coreboot/+/56339/comment/020fe3de_6bc47e26 PS2, Line 9: Openbmc OpenBMC
https://review.coreboot.org/c/coreboot/+/56339/comment/705272b3_8499f6b9 PS2, Line 11: It’d be great if you could document if you wrote this from scratch or used some other board as template.
https://review.coreboot.org/c/coreboot/+/56339/comment/5756c155_ffc2214c PS2, Line 21: options Option ROM?
Patchset:
PS4: Awesome!
File src/mainboard/asrock/e3c246d4i/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56339/comment/068fe1a1_4f5a09d0 PS2, Line 47: device pci 12.0 on end # Thermal Subsystem Should the comments be aligned?
File src/mainboard/asrock/e3c246d4i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/56339/comment/2aa35d5c_dacad76a PS2, Line 27: Please remove the blank line.
-
Paul Menzel (Code Review)