Change in coreboot[master]: mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48243 )
Change subject: mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET ......................................................................
mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET
TEST=Timeless build results in identical image.
Change-Id: Ifa5c14add555b382f74ba1165131b1569bbef123 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/48243/1
diff --git a/src/mainboard/amd/mandolin/Makefile.inc b/src/mainboard/amd/mandolin/Makefile.inc index 795a28f..448c12a 100644 --- a/src/mainboard/amd/mandolin/Makefile.inc +++ b/src/mainboard/amd/mandolin/Makefile.inc @@ -21,7 +21,6 @@
ifeq ($(CONFIG_MANDOLIN_HAVE_MCHP_FW),y)
-MANDOLIN_MICROCHIP_FW_OFFSET=0 add_mchp_fw: $(obj)/coreboot.pre $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_MANDOLIN_MCHP_FW_FILE) --fill-upward
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48243 )
Change subject: mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48243 )
Change subject: mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET ......................................................................
mb/amd/mandolin: removed unused MANDOLIN_MICROCHIP_FW_OFFSET
TEST=Timeless build results in identical image.
Change-Id: Ifa5c14add555b382f74ba1165131b1569bbef123 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48243 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/amd/mandolin/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/Makefile.inc b/src/mainboard/amd/mandolin/Makefile.inc index 795a28f..448c12a 100644 --- a/src/mainboard/amd/mandolin/Makefile.inc +++ b/src/mainboard/amd/mandolin/Makefile.inc @@ -21,7 +21,6 @@
ifeq ($(CONFIG_MANDOLIN_HAVE_MCHP_FW),y)
-MANDOLIN_MICROCHIP_FW_OFFSET=0 add_mchp_fw: $(obj)/coreboot.pre $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_MANDOLIN_MCHP_FW_FILE) --fill-upward
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)