Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80459?usp=email )
Change subject: mb/clevo/tgl-u: Use enum for AZALIA_PIN_CFG misc field ......................................................................
mb/clevo/tgl-u: Use enum for AZALIA_PIN_CFG misc field
Use the new JACK_PRESENCE_DETECT and NO_JACK_PRESENCE_DETECT enums instead of raw values in the misc field of AZALIA_PIN_CFG.
TEST: Timeless build for clevo/tgl-u did not change
Change-Id: Ic3f4128ecbf89ddce3b6e705ebef76da343a433c Signed-off-by: Nicholas Chin nic.c3.14@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80459 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c 1 file changed, 11 insertions(+), 11 deletions(-)
Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c b/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c index d8739a2..0ff24a2 100644 --- a/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c +++ b/src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c @@ -18,7 +18,7 @@ MIC_IN, OTHER_DIGITAL, COLOR_UNKNOWN, - 1, /* no presence detect */ + NO_JACK_PRESENCE_DETECT, 3, 0) ),
@@ -30,7 +30,7 @@ SPEAKER, OTHER_ANALOG, COLOR_UNKNOWN, - 1, /* no presence detect */ + NO_JACK_PRESENCE_DETECT, 1, 0) ),
@@ -42,7 +42,7 @@ HP_OUT, STEREO_MONO_1_8, BLACK, - 0, /* has presence detect */ + JACK_PRESENCE_DETECT, 2, 0) ),
@@ -54,19 +54,19 @@ MIC_IN, STEREO_MONO_1_8, BLACK, /* vendor: PINK */ - 1, /* no separate presence detect */ + NO_JACK_PRESENCE_DETECT, 3, 12) ),
/* PCBEEP, vendor value: 0x41748245 */ AZALIA_PIN_CFG(0, 0x1d, AZALIA_PIN_DESC( - INTEGRATED, /* vendor: NC */ - INTERNAL, /* vendor: EXTERNAL_PRIMARY_CHASSIS */ - NA, /* vendor: REAR */ - DEVICE_OTHER, /* vendor: MODEM_HANDSET_SIDE */ - OTHER_ANALOG, /* vendor: RCA */ - COLOR_UNKNOWN, /* vendor: PURPLE */ - 1, /* no presence detect, vendor: 2 */ + INTEGRATED, /* vendor: NC */ + INTERNAL, /* vendor: EXTERNAL_PRIMARY_CHASSIS */ + NA, /* vendor: REAR */ + DEVICE_OTHER, /* vendor: MODEM_HANDSET_SIDE */ + OTHER_ANALOG, /* vendor: RCA */ + COLOR_UNKNOWN, /* vendor: PURPLE */ + NO_JACK_PRESENCE_DETECT, /* vendor: 2 */ 4, 5) ),