Change in coreboot[master]: mb/google/zork/: add edp tunning parameter to fix the edp noise

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

chris wang (Code Review)

17 Dec 2020 17 Dec '20

11:04 p.m.

Hello Chris Wang,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to review the following change.

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

mb/google/zork/: add edp tunning parameter to fix the edp noise

needs to adjust edp phy setting to fix the edp noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/1

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a3c2c97..b6a886c 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -23,6 +23,19 @@ register "telemetry_vddcr_soc_slope_mA" = "20001" register "telemetry_vddcr_soc_offset" = "168"

+ # eDP phy tunning settings + register "dp_phy_override" = "ENABLE_EDP_TUNINGSET" + register "edp_phy_sel" = "0x1" + register "edp_version" = "0x0" + register "edp_table_size" = "0x05" + + register "edp_tuningset" = "{ + .dp_vs_pemph_level = 0x0, + .deemph_6db4 = 0x004b, + .boostadj = 0x0, + .margin_deemph = 0x80, + }" + # USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

build bot (Jenkins) (Code Review)

17 Dec 17 Dec

11:04 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48734/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/1/src/mainboard/google/zork/v... PS1, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

chris wang (Code Review)

11:05 p.m.

Hello Chris Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to look at the new patch set (#2).

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

mb/google/zork/: add edp tunning parameter to fix the edp noise

needs to adjust edp phy setting to fix the edp noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was pass to system integrated table

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/2

Paul Menzel (Code Review)

28 Dec 28 Dec

2:22 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48734/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/2//COMMIT_MSG@7 PS2, Line 7: mb/google/zork/ Please remove the trailing /.

build bot (Jenkins) (Code Review)

11 Jan 11 Jan

11:39 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/d288ac78_6c51046f PS3, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

build bot (Jenkins) (Code Review)

12 Jan 12 Jan

2:01 a.m.

Attention is currently required from: chris wang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork/: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/c225708f_afbbe8b9 PS4, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

chris wang (Code Review)

5:22 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: chris wang. Hello build bot (Jenkins), Chris Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to look at the new patch set (#5).

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

mb/google/zork: add edp tunning parameter to fix the edp noise

needs to adjust edp phy setting to fix the edp noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/5

chris wang (Code Review)

5:24 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 5:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/comment/bb8d5b11_a9eca86f PS2, Line 7: mb/google/zork/

...

Please remove the trailing /.

Done

build bot (Jenkins) (Code Review)

5:24 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/0fd6915e_4ec78456 PS5, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

Felix Held (Code Review)

13 Jan 13 Jan

6:04 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, chris wang. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/508e6dde_d8df7dfe PS5, Line 30: register "edp_table_size" = "0x05" haven't really figured out what this does on the fsp side exactly, but it does seem rather odd to me, since i have the impression that this is just the constant size of edp_tuningset

Nikolai Vyssotski (Code Review)

14 Jan 14 Jan

10:48 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, chris wang, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/6697fb5b_e2f7548f PS5, Line 30: register "edp_table_size" = "0x05"

...

haven't really figured out what this does on the fsp side exactly, but it does seem rather odd to me […]

I would think this would be the resulting size of dptuning[] table that gets initialized in FSP. Current FSP implementation is only using one of the entries in the table (1 * sizeof(edp_tuningset)) which results in 5 byte table. We do need to double check if the units here are bytes or number of valid edp_tuningset(s) which would be 1 in this case. Adding Eddie to the review to verify.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 5 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Thu, 14 Jan 2021 18:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

Nikolai Vyssotski (Code Review)

1:04 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, chris wang, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/cf20de1e_b47b663d PS5, Line 30: register "edp_table_size" = "0x05"

...

I would think this would be the resulting size of dptuning[] table that gets initialized in FSP. […]

After talking to Eddie and looking at VBIOS spec it does appear that 5 is correct. This is the size of the dptuning[] resulting table passed to VBIOS in bytes counting only valid entries. However this number can not be anything but 5 here since we will always have one table entry filled from edp_tuningset structure fields below. Should we even pass it between CB and FSP? It maybe a good thing to have in case we ever decide to fill in more than one entry but even then it would probably be better to keep it as a count of settings (n) here and then do n * sizeof(edp_tuningset) math for table_size in FSP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 5 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Thu, 14 Jan 2021 21:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

20 Jan 20 Jan

11:47 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, chris wang, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 6:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/bf2aad9f_1a2c6a20 PS6, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

chris wang (Code Review)

21 Jan 21 Jan

11:03 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, chris wang, Felix Held. Hello build bot (Jenkins), Chris Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to look at the new patch set (#8).

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

mb/google/zork: add edp tunning parameter to fix the edp noise

needs to adjust edp phy setting to fix the edp noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/8

chris wang (Code Review)

11:06 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Paul Menzel, Nikolai Vyssotski, Felix Held. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 8:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/03c2dbd1_4b6b9724 PS5, Line 30: register "edp_table_size" = "0x05"

...

After talking to Eddie and looking at VBIOS spec it does appear that 5 is correct. […]

had remove the dp_sel and tablesize and dp version. only keep the dp override type. will clean up the related UPD in later changeing.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 8 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Thu, 21 Jan 2021 19:06:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11:26 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Furquan Shaikh, Paul Menzel, Nikolai Vyssotski, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 8:

(1 comment)

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/236c71ee_c0dad07a PS8, Line 26: # eDP phy tunning settings 'tunning' may be misspelled - perhaps 'tuning'?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 8 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Thu, 21 Jan 2021 19:26:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

24 Jan 24 Jan

8:20 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add edp tunning parameter to fix the edp noise

Attention is currently required from: Furquan Shaikh, Kangheui Won, Paul Menzel, Nikolai Vyssotski, chris wang, Felix Held. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................

Patch Set 8:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/comment/0f2cde98_ae7ac663 PS8, Line 7: edp nits: eDP for all edp in the comment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 8 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Mon, 25 Jan 2021 04:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

chris wang (Code Review)

9:13 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tunning parameter to fix the eDP noise

Attention is currently required from: Furquan Shaikh, Kangheui Won, Paul Menzel, Nikolai Vyssotski, chris wang, Felix Held. Hello build bot (Jenkins), Furquan Shaikh, Kangheui Won, Nikolai Vyssotski, Chris Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to look at the new patch set (#9).

Change subject: mb/google/zork: add eDP tunning parameter to fix the eDP noise ......................................................................

mb/google/zork: add eDP tunning parameter to fix the eDP noise

needs to adjust eDP phy setting to fix the eDP noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 9 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: newpatchset

chris wang (Code Review)

9:17 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tunning parameter to fix the eDP noise

Attention is currently required from: Furquan Shaikh, Kangheui Won, Paul Menzel, Nikolai Vyssotski, EricR Lai, Felix Held. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add eDP tunning parameter to fix the eDP noise ......................................................................

Patch Set 9:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/comment/71db6fcc_c0511086 PS8, Line 7: edp

...

nits: eDP for all edp in the comment.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 9 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Mon, 25 Jan 2021 05:17:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

9:19 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tunning parameter to fix the eDP noise

Change subject: mb/google/zork: add eDP tunning parameter to fix the eDP noise ......................................................................

Patch Set 9: Code-Review+2

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/comment/d6d5cd46_41f9d899 PS9, Line 7: tunning nit: tuning

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/f7105eb2_e074ccbe PS9, Line 26: tunning nits: tuning

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 9 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Mon, 25 Jan 2021 05:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

chris wang (Code Review)

9:27 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tuning parameter to fix the eDP noise

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48734

to look at the new patch set (#10).

Change subject: mb/google/zork: add eDP tuning parameter to fix the eDP noise ......................................................................

mb/google/zork: add eDP tuning parameter to fix the eDP noise

needs to adjust the eDP phy setting to fix the eDP noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48734/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 10 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: newpatchset

chris wang (Code Review)

9:31 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tuning parameter to fix the eDP noise

Change subject: mb/google/zork: add eDP tuning parameter to fix the eDP noise ......................................................................

Patch Set 10:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48734/comment/a80b9041_62e9a390 PS9, Line 7: tunning

...

nit: tuning

Done

File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48734/comment/4bc9e8da_2aefafd4 PS9, Line 26: tunning

...

nits: tuning

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 10 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Mon, 25 Jan 2021 05:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

9:36 p.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tuning parameter to fix the eDP noise

Change subject: mb/google/zork: add eDP tuning parameter to fix the eDP noise ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Gerrit-Change-Number: 48734 Gerrit-PatchSet: 10 Gerrit-Owner: chris wang Chris.Wang@amd.com Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Kangheui Won khwon@chromium.org Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Attention: chris wang Chris.Wang@amd.com Gerrit-Attention: Felix Held felix-coreboot@felixheld.de Gerrit-Comment-Date: Mon, 25 Jan 2021 05:36:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

25 Jan 25 Jan

1:10 a.m.

New subject: Change in coreboot[master]: mb/google/zork: add eDP tuning parameter to fix the eDP noise

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48734 )

Change subject: mb/google/zork: add eDP tuning parameter to fix the eDP noise ......................................................................

mb/google/zork: add eDP tuning parameter to fix the eDP noise

needs to adjust the eDP phy setting to fix the eDP noise for WWAN.

DP_VS_LEVEL0_PREEMPH_LEVEL0, = 0x00 (0.4v 0db) swing 0, pre-emphasis 0) COMMON_MAR_DEEMPH_NOM = 0x004B COMMON_SELDEEMPH60 = 0x0 CMD_BUS_GLOBAL_FOR_TX_LANE0 = 0x80

BUG=b:171269338 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table

Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48734 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index f484e9a..ddcaf53 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -23,6 +23,16 @@ register "telemetry_vddcr_soc_slope_mA" = "20001" register "telemetry_vddcr_soc_offset" = "168"

+ # eDP phy tuning settings + register "dp_phy_override" = "ENABLE_EDP_TUNINGSET" + + register "edp_tuningset" = "{ + .dp_vs_pemph_level = 0x0, + .deemph_6db4 = 0x004b, + .boostadj = 0x0, + .margin_deemph = 0x80, + }" + # USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1

1467

days inactive

1505

days old

coreboot-gerrit@coreboot.org

23 comments

7 participants

tags (0)

participants (7)

build bot (Jenkins) (Code Review)
chris wang (Code Review)
EricR Lai (Code Review)
Felix Held (Code Review)
Nikolai Vyssotski (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)