Change in coreboot[master]: mb/amd/mandolin: use more readable size formats in FMAP files
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48245 )
Change subject: mb/amd/mandolin: use more readable size formats in FMAP files ......................................................................
mb/amd/mandolin: use more readable size formats in FMAP files
Since the FMD file isn't parsed any more by a shell script in the SoC's Makefile.inc, we can use better human-readable numbers for the section sizes.
TEST=Timeless build results in identical image.
Change-Id: I2117064a694f67767284f6fd4ac3604b254a2734 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/cereme/board.fmd M src/mainboard/amd/mandolin/variants/mandolin/board.fmd 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48245/1
diff --git a/src/mainboard/amd/mandolin/variants/cereme/board.fmd b/src/mainboard/amd/mandolin/variants/cereme/board.fmd index b55b8b5..442d80f 100644 --- a/src/mainboard/amd/mandolin/variants/cereme/board.fmd +++ b/src/mainboard/amd/mandolin/variants/cereme/board.fmd @@ -1,8 +1,8 @@ FLASH@0xFF000000 16M { BIOS { - EC 0x20000 - RW_MRC_CACHE 0x10000 - FMAP 0x1000 + EC 128K + RW_MRC_CACHE 64K + FMAP 4K COREBOOT(CBFS) } } diff --git a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd index 2845e64..33b281d 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd +++ b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd @@ -1,8 +1,8 @@ FLASH@0xFF800000 8M { BIOS { - EC 0x20000 + EC 128K RW_MRC_CACHE 64K - FMAP 0x1000 + FMAP 4K COREBOOT(CBFS) } }
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48245 )
Change subject: mb/amd/mandolin: use more readable size formats in FMAP files ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48245 )
Change subject: mb/amd/mandolin: use more readable size formats in FMAP files ......................................................................
mb/amd/mandolin: use more readable size formats in FMAP files
Since the FMD file isn't parsed any more by a shell script in the SoC's Makefile.inc, we can use better human-readable numbers for the section sizes.
TEST=Timeless build results in identical image.
Change-Id: I2117064a694f67767284f6fd4ac3604b254a2734 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48245 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/amd/mandolin/variants/cereme/board.fmd M src/mainboard/amd/mandolin/variants/mandolin/board.fmd 2 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/variants/cereme/board.fmd b/src/mainboard/amd/mandolin/variants/cereme/board.fmd index b55b8b5..442d80f 100644 --- a/src/mainboard/amd/mandolin/variants/cereme/board.fmd +++ b/src/mainboard/amd/mandolin/variants/cereme/board.fmd @@ -1,8 +1,8 @@ FLASH@0xFF000000 16M { BIOS { - EC 0x20000 - RW_MRC_CACHE 0x10000 - FMAP 0x1000 + EC 128K + RW_MRC_CACHE 64K + FMAP 4K COREBOOT(CBFS) } } diff --git a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd index 2845e64..33b281d 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd +++ b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd @@ -1,8 +1,8 @@ FLASH@0xFF800000 8M { BIOS { - EC 0x20000 + EC 128K RW_MRC_CACHE 64K - FMAP 0x1000 + FMAP 4K COREBOOT(CBFS) } }
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)