Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85283?usp=email )
Change subject: soc/intel/common/block: Add const qualifier for input of pirq ops ......................................................................
soc/intel/common/block: Add const qualifier for input of pirq ops
Add const qualifer for itss_get_on_chip_dev_pirq and itss_soc_get_on_chip_dev_pir so that these ops could be used for both struct device * input and const struct device * input.
Change-Id: I65b4de3f51b109bfcabfaa0ebe47a22bdd69d1a0 Signed-off-by: Shuo Liu shuo.liu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85283 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: yuchi.chen@intel.com --- M src/soc/intel/common/block/include/intelblocks/itss.h M src/soc/intel/common/block/itss/itss.c M src/soc/intel/snowridge/itss.c 3 files changed, 4 insertions(+), 4 deletions(-)
Approvals: Angel Pons: Looks good to me, approved build bot (Jenkins): Verified yuchi.chen@intel.com: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/include/intelblocks/itss.h b/src/soc/intel/common/block/include/intelblocks/itss.h index 45a71cc..0a9e365 100644 --- a/src/soc/intel/common/block/include/intelblocks/itss.h +++ b/src/soc/intel/common/block/include/intelblocks/itss.h @@ -48,10 +48,10 @@ void itss_clock_gate_8254(void);
/* SoC implementation to return corresponding PIR register offset. */ -uint32_t itss_soc_get_on_chip_dev_pir(struct device *dev); +uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev);
/* Return which PIRQx the device's INTx is connected to. */ -enum pirq itss_get_on_chip_dev_pirq(struct device *dev, enum pci_pin pin); +enum pirq itss_get_on_chip_dev_pirq(const struct device *dev, enum pci_pin pin);
#endif /* !defined(__ACPI__) */
diff --git a/src/soc/intel/common/block/itss/itss.c b/src/soc/intel/common/block/itss/itss.c index 4d9b7a5..e2ff3ef 100644 --- a/src/soc/intel/common/block/itss/itss.c +++ b/src/soc/intel/common/block/itss/itss.c @@ -135,7 +135,7 @@ show_irq_polarities("After"); }
-enum pirq itss_get_on_chip_dev_pirq(struct device *dev, enum pci_pin pin) +enum pirq itss_get_on_chip_dev_pirq(const struct device *dev, enum pci_pin pin) { /* Check if device is on chip. */ if (dev->upstream->dev->path.type != DEVICE_PATH_DOMAIN) diff --git a/src/soc/intel/snowridge/itss.c b/src/soc/intel/snowridge/itss.c index 07f5b1d..7f2b567 100644 --- a/src/soc/intel/snowridge/itss.c +++ b/src/soc/intel/snowridge/itss.c @@ -11,7 +11,7 @@
#include "ramstage.h"
-uint32_t itss_soc_get_on_chip_dev_pir(struct device *dev) +uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev) { /* Check if device is on chip. */ if (dev->upstream->dev->path.type != DEVICE_PATH_DOMAIN)