Attention is currently required from: Jayvik Desai, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83667?usp=email )
Change subject: vc/google/chromeos/Kconfig: Enable config to determine eSOL status
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
ideally you can split this into three cls […]
Splited the change as suggested.
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/83667/comment/a9d94998_351fcfe4?usp... :
PS1, Line 55: MAINBOARD_HAS_EARLY_SIGN_OF_LIFE
eSOL is a chromeos feature then why this is here ? i would request to have the config added as part […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83667?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68aca8033cf843e8a569339ab1af85fab104b36a
Gerrit-Change-Number: 83667
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 19:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com