Attention is currently required from: Nigel Tao.
Nico Huber has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/84340?usp=email )
Change subject: lib/jpeg: enable dst-pixel-format allowlist ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
What do you think?
Technically, it's undefined. Some people run VGA option roms in coreboot, and then you get the framebuffer format that the option rom supports. Which also shows an issue here: It looks like when the wuffs decoder was added, the format was hardcoded. I guess to mimic the old decoder.
Saving space is much appreciate, still. What we could do here could be to decide the format based on Kconfig options. For every gfx init option except for the option rom we should know the format, including the color depth, at compile time. If this is something you would like to explore, I could have a look at translating the options to the pixel format.