Attention is currently required from: Jakub Czapiga, Jan Dabros, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60080 )
Change subject: libpayload: Enable vboot integration ......................................................................
Patch Set 5:
(4 comments)
File payloads/libpayload/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/60080/comment/8ad84b3d_8e42fcd4 PS5, Line 5: menu "Verified boot (vboot)" You don't have a menu for CBFS so I don't think you should have one here either. (Instead, if you want to make things look a little prettier in menuconfig, you could indent the dependent options a bit, e.g. "-> TPM2 Mode" or something like that.)
https://review.coreboot.org/c/coreboot/+/60080/comment/adb39aaa_74d74af5 PS5, Line 22: config VBOOT_TEST_PRINT Now you took VBOOT_DEBUG out but added this? We shouldn't need any of this. Just always enable debug messages. There is no reason to do anything special for ARCH_MOCK here. (Unit tests here are still the libpayload/depthcharge unit tests, not the vboot unit tests, so the vboot code called by them is still just firmware code that calls vb2ex_printf() and not printf() directly. libpayload/depthcharge can then decide whether that callback actually prints something or not with their own unit test printing configs.)
File payloads/libpayload/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60080/comment/adf7a8f7_b5e29e91 PS3, Line 23: VBOOT_FIRMWARE_ARCH-$(CONFIG_LP_ARCH_ARM64) := arm64
I intentionally left it without any check, because I wanted to allow building vboot for ARCH_MOCK. […]
Ack
File payloads/libpayload/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60080/comment/a6e429a8_e6d585cc PS5, Line 47: $(VBOOT_BUILD_DIR)/vboot_fw.a Why not just use the `fwlib` target here?
-
Julius Werner (Code Review)