Attention is currently required from: Henry Sun, Simon Yang, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75872?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add GPIO table for gothrax
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/gothrax/memory.c:
https://review.coreboot.org/c/coreboot/+/75872/comment/113389e7_bdcf12c9 :
PS3, Line 13: if (board_id() == 0)
Do you need this for Gothrax power on?
This code is not needed.
Thanks for the tip.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If852c7a30edb9fb778872414cb15dc3446aebc55
Gerrit-Change-Number: 75872
Gerrit-PatchSet: 4
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Comment-Date: Wed, 21 Jun 2023 02:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Gerrit-MessageType: comment