HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46188 )
Change subject: mb/kontron/ktqm77: Convert to ASL 2.0 syntax ......................................................................
mb/kontron/ktqm77: Convert to ASL 2.0 syntax
Change-Id: I7ba4625075fd3c27092d854903baf140521c8f7b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/kontron/ktqm77/acpi/platform.asl M src/mainboard/kontron/ktqm77/acpi/thermal.asl 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/46188/1
diff --git a/src/mainboard/kontron/ktqm77/acpi/platform.asl b/src/mainboard/kontron/ktqm77/acpi/platform.asl index cc45619..a0e255c 100644 --- a/src/mainboard/kontron/ktqm77/acpi/platform.asl +++ b/src/mainboard/kontron/ktqm77/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { /* Let suspend LED flash slowly in S3 and S4 */ - If (LOr (LEqual (Arg0, 3), LEqual (Arg0, 4))) + If ((Arg0 == 3) || (Arg0 == 4)) { _SB.PCI0.LPCB.SIO0.SUSL (0x06) } diff --git a/src/mainboard/kontron/ktqm77/acpi/thermal.asl b/src/mainboard/kontron/ktqm77/acpi/thermal.asl index 2400493..3465b75 100644 --- a/src/mainboard/kontron/ktqm77/acpi/thermal.asl +++ b/src/mainboard/kontron/ktqm77/acpi/thermal.asl @@ -21,10 +21,10 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46188 )
Change subject: mb/kontron/ktqm77: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46188 )
Change subject: mb/kontron/ktqm77: Convert to ASL 2.0 syntax ......................................................................
mb/kontron/ktqm77: Convert to ASL 2.0 syntax
Change-Id: I7ba4625075fd3c27092d854903baf140521c8f7b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46188 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/kontron/ktqm77/acpi/platform.asl M src/mainboard/kontron/ktqm77/acpi/thermal.asl 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/kontron/ktqm77/acpi/platform.asl b/src/mainboard/kontron/ktqm77/acpi/platform.asl index cc45619..a0e255c 100644 --- a/src/mainboard/kontron/ktqm77/acpi/platform.asl +++ b/src/mainboard/kontron/ktqm77/acpi/platform.asl @@ -7,7 +7,7 @@ Method(_PTS,1) { /* Let suspend LED flash slowly in S3 and S4 */ - If (LOr (LEqual (Arg0, 3), LEqual (Arg0, 4))) + If ((Arg0 == 3) || (Arg0 == 4)) { _SB.PCI0.LPCB.SIO0.SUSL (0x06) } diff --git a/src/mainboard/kontron/ktqm77/acpi/thermal.asl b/src/mainboard/kontron/ktqm77/acpi/thermal.asl index 2400493..3465b75 100644 --- a/src/mainboard/kontron/ktqm77/acpi/thermal.asl +++ b/src/mainboard/kontron/ktqm77/acpi/thermal.asl @@ -21,10 +21,10 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)