Hello Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31114
to review the following change.
Change subject: mb/lenovo/z61t/acpi_tables: Add critical and passive threshold ......................................................................
mb/lenovo/z61t/acpi_tables: Add critical and passive threshold
Add critical and passive threshold to be advertised in thermal zone 0.
This commit follows up on commit afa627db with Change-Id Ic75a80994b27ac19651ed52b7fc3c00c65cd9c01.
Change-Id: I7d645818d2b2f6b7c16d2d813bf982a55774561d Signed-off-by: Patrick Rudolph siro@das-labor.org Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/z61t/acpi_tables.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31114/1
diff --git a/src/mainboard/lenovo/z61t/acpi_tables.c b/src/mainboard/lenovo/z61t/acpi_tables.c index 3e9a810..183b7fe 100644 --- a/src/mainboard/lenovo/z61t/acpi_tables.c +++ b/src/mainboard/lenovo/z61t/acpi_tables.c @@ -23,4 +23,7 @@ gnvs->cmap = 0x01; gnvs->cmbp = 0x01;
+ /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; }
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31114 )
Change subject: mb/lenovo/z61t/acpi_tables: Add critical and passive threshold ......................................................................
Patch Set 1:
What values does vendor firmware set ?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31114 )
Change subject: mb/lenovo/z61t/acpi_tables: Add critical and passive threshold ......................................................................
Patch Set 1: Code-Review+1
Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31114 )
Change subject: mb/lenovo/z61t/acpi_tables: Add critical and passive threshold ......................................................................
Abandoned
Abandoned in favour of Change-Id: If569f67c932b7fbf14893b890a5588df4994daeb