Attention is currently required from: Felix Singer, Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )
Change subject: soc/intel/common/systemagent: Improve systemagent ......................................................................
Patch Set 10:
(2 comments)
File src/soc/intel/common/block/systemagent/systemagent_def.h:
https://review.coreboot.org/c/coreboot/+/83318/comment/44198072_c9024434?usp... : PS3, Line 73: * IS_LIMIT = If registers/offset indicates address limit or address limit plus 1.
Rename is_limit to fix_up_limit?
fixup_limit
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/9e3bd43e_263e876f?usp... : PS10, Line 138: return ALIGN_DOWN(tolud, CONFIG_TOLUD_ALIGNMENT); if (CONFIG(SA_MEMMAP_FIXUP_LIMIT)) // to load and fixup the value otherwise // normal routine
P.S. a common routine to fixup limit could be made to used commonly between sa codes and early as codes.