Julius Werner has posted comments on this change. ( https://review.coreboot.org/19863 )
Change subject: google/gru: enable the pull high for touchpad
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19863/2/src/mainboard/google/gru/romstage.c
File src/mainboard/google/gru/romstage.c:
Line 81: prepare_i2c();
I think that's fine. Why should be put it in ramstage?
In general everything should be put in ramstage unless there's a specific reason to do it earlier.
--
To view, visit
https://review.coreboot.org/19863
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang
wxt@rock-chips.com
Gerrit-Reviewer: Caesar Wang
wxt@rock-chips.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes