Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang.
Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/83bbcb61_fb716362?usp... : PS5, Line 8: #include <fw_config.h> <*.h> should be separated from ".h" by a blank line. Within each group, the headers should be sorted.
https://review.coreboot.org/c/coreboot/+/83287/comment/423fc2f9_f3e2b5fe?usp... : PS5, Line 63: fw_config_probe Align with the fw_config_probe in the previous line.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/52beccf0_24cb19a5?usp... : PS5, Line 6: #include <fw_config.h> Same here.
https://review.coreboot.org/c/coreboot/+/83287/comment/9cd163a0_aeead537?usp... : PS5, Line 34: { Remove `{}`.