Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56909
to review the following change.
Change subject: mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B ......................................................................
mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B
Add SPD support to lantis for MT53E512M32D1NP-046 WT:B
BUG=None BRANCH=firmware-dedede-13606.B TEST=FW_NAME=lantis emerge-dedede coreboot chromeos-bootimage
Change-Id: I22c50a55dd3b8bbda64ba1b607c8b22cc6592f98 --- M src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc M src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt 3 files changed, 3 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/56909/1
diff --git a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc index f6282bf..a934428 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc @@ -2,4 +2,4 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B diff --git a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt index 856d016..e8ec694 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt @@ -2,3 +2,4 @@ MT53E512M32D2NP-046 WT:E 0 (0000) H9HCNNNBKMMLXR-NEE 0 (0000) K4U6E3S4AA-MGCR 0 (0000) +MT53E512M32D1NP-046 WT:B 0 (0000) diff --git a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt index 1bcd3da..09ed381 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt @@ -1,14 +1,4 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. -# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. - -# Part Name MT53E512M32D2NP-046 WT:E H9HCNNNBKMMLXR-NEE K4U6E3S4AA-MGCR +MT53E512M32D1NP-046 WT:B