Attention is currently required from: Paul Menzel, Shelley Chen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79888?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Enable WLAN on root port 5
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79888/comment/39f7febb_c1cd981d :
PS12, Line 185: PCIe 5 using clk 1
Quite duplicated, isn't it? Please don't document the devicetree in comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I361bef13ebd073b6fccb729a1960d3832cf2681a
Gerrit-Change-Number: 79888
Gerrit-PatchSet: 12
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 17 Jan 2024 22:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment