[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions - coreboot-gerrit

25 Apr 2023


      Attention is currently required from: Lance Zhao, Martin L Roth, Subrata Banik, Lean Sheng Tan, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 )
Change subject: acpi/acpi.c: Reduce scope of some functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
can you elaborate more on the commit message? it is too vague.
I'm not sure what you want. Reducing the scope of both functions and variables is an ubiquitous pattern in most programming language.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74756
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2
Gerrit-Change-Number: 74756
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jan Samek jan.samek@siemens.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 19:13:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-MessageType: comment