Attention is currently required from: Furquan Shaikh, Martin Roth.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 )
Change subject: mb/google/guybrush: Update GPIO configuration
......................................................................
Patch Set 3: -Code-Review
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/5d0b7afa_deb6efe6
PS3, Line 16: /* GSC_SOC_INT_L */
Why are all these pads dropped from the ramstage table? For all boards, we ensure that the ramstage […]
Hmm, had never heard that policy before. Not that I think it's bad. Did that happen to get documented anywhere?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I512cb8b435dc8412cd46189e741ad94e5a24699e
Gerrit-Change-Number: 51675
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 23 Mar 2021 02:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment