Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85745?usp=email )
Change subject: mb/google/corsola: Refactor mipi_panel_power_on function
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85745/comment/26487b41_0517afd9?usp... :
PS6, Line 7: mb/google/corsola: refactor mipi_panel_power_on function
Upper case Refactor
Done
File src/mainboard/google/corsola/panel_starmie.c:
https://review.coreboot.org/c/coreboot/+/85745/comment/caf49275_ce1d4457?usp... :
PS6, Line 4: #include <delay.h>
: #include <gpio.h>
: #include <soc/regulator.h>
unused includes ?
Done
File src/mainboard/google/corsola/panel_tps65132s.c:
https://review.coreboot.org/c/coreboot/+/85745/comment/6774b48b_e0bb52c3?usp... :
PS6, Line 14: const struct tps65132s_reg_setting reg_settings[] = {
Tab after const
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0561e57d99ab55e6dcbb7744b2228c4cebb0d88
Gerrit-Change-Number: 85745
Gerrit-PatchSet: 7
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 24 Dec 2024 14:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com