Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/36798 )
Change subject: Enforce file sorting for flash chips ......................................................................
Enforce file sorting for flash chips
Adding LANG=C will make sure that the order in which files are pulled into em100pro_chips.h does not change from machine to machine (and thus creates a lot of churn on the file in the tree) This will make future updates more readable
Change-Id: I8c12b17d51cd3c52bd393b0aee01246fe9c8f416 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/98/36798/1
diff --git a/Makefile b/Makefile index 4afe901..0518c6f 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@
em100pro_chips.h: makechips.sh printf " CREATE em100pro_chips.sh & firmware images\n" - ./makechips.sh + LANG=C ./makechips.sh
makechips.sh: makedpfw makechips
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36798 )
Change subject: Enforce file sorting for flash chips ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/em100/+/36798 )
Change subject: Enforce file sorting for flash chips ......................................................................
Enforce file sorting for flash chips
Adding LANG=C will make sure that the order in which files are pulled into em100pro_chips.h does not change from machine to machine (and thus creates a lot of churn on the file in the tree) This will make future updates more readable
Change-Id: I8c12b17d51cd3c52bd393b0aee01246fe9c8f416 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/36798 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/Makefile b/Makefile index 4afe901..0518c6f 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@
em100pro_chips.h: makechips.sh printf " CREATE em100pro_chips.sh & firmware images\n" - ./makechips.sh + LANG=C ./makechips.sh
makechips.sh: makedpfw makechips
-
Duncan Laurie (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)