Sridhar Siricilla has uploaded a new patch set (#26) to the change originally created by Rizwan Qureshi. ( https://review.coreboot.org/c/coreboot/+/35546 )
Change subject: soc/intel/{common,skl,cnl,icl,apl,tgl}: Move HFSTS1 register definition to SoC ......................................................................
soc/intel/{common,skl,cnl,icl,apl,tgl}: Move HFSTS1 register definition to SoC
Below changes are implemented: 1. Move HFSTS1 register definition & related macros from common code to SoC since HFSTS1 register definition is specific to a SoC. Moving structure back to SoC specific to avoid unnecessay SoC specific macros.
2. The current CSE library code relies on CSE Current Working State and Current Operation Mode. Declare a set of APIs to retrieve this information. These APIs should be defined in the SoC specific code. cse_is_hfs1_com_normal(void) cse_is_hfs1_com_secover_mei_msg(void) cse_is_hfs1_com_soft_temp_disable(void) cse_is_hfs1_cws_normal(void) This callback mechanism decouples the common code implementation from the nuances of SoC specific CSE HFSTS1 definitions.
3. Modify existing code to use callbacks to get data of me_hfs1 structure.
TEST=Build and Boot hatch, soraka, tglrvp, bobba and iclrvp boards.
Change-Id: If7ea6043d7b5473d0c16e83d7b2d4b620c125652 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/apollolake/cse.c A src/soc/intel/apollolake/include/soc/me.h M src/soc/intel/cannonlake/include/soc/me.h M src/soc/intel/cannonlake/me.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/icelake/Makefile.inc A src/soc/intel/icelake/include/soc/me.h A src/soc/intel/icelake/me.c M src/soc/intel/skylake/include/soc/me.h M src/soc/intel/skylake/me.c M src/soc/intel/tigerlake/Makefile.inc A src/soc/intel/tigerlake/include/soc/me.h A src/soc/intel/tigerlake/me.c 14 files changed, 457 insertions(+), 51 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35546/26