Change in coreboot[master]: doc/getting_started: update name of file generated by "make savedefco...
Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43973 )
Change subject: doc/getting_started: update name of file generated by "make savedefconfig" ......................................................................
doc/getting_started: update name of file generated by "make savedefconfig"
Update kconfig.md to reflect that defconfig (instead of mini-config) file is generated by running "make savedefconfig".
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I4075e5b51e3c504eaad25e3abfc52ba593364ee9 --- M Documentation/getting_started/kconfig.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/43973/1
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index ecdfe62..ff8d3dc 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -52,7 +52,7 @@ not have an answer yet, it stops and queries the user for the desired value. - olddefconfig - Generates a config, using the default value for any symbols not listed in the .config file. -- savedefconfig - Creates a ‘mini-config’ file, stripping out all of the symbols +- savedefconfig - Creates a ‘defconfig’ file, stripping out all of the symbols that were left as default values. This is very useful for debugging, and is how config files should be saved. - silentoldconfig - This evaluates the .config file the same way that the
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43973 )
Change subject: doc/getting_started: update name of file generated by "make savedefconfig" ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43973 )
Change subject: doc/getting_started: update name of file generated by "make savedefconfig" ......................................................................
doc/getting_started: update name of file generated by "make savedefconfig"
Update kconfig.md to reflect that defconfig (instead of mini-config) file is generated by running "make savedefconfig".
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I4075e5b51e3c504eaad25e3abfc52ba593364ee9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43973 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/getting_started/kconfig.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index ecdfe62..ff8d3dc 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -52,7 +52,7 @@ not have an answer yet, it stops and queries the user for the desired value. - olddefconfig - Generates a config, using the default value for any symbols not listed in the .config file. -- savedefconfig - Creates a ‘mini-config’ file, stripping out all of the symbols +- savedefconfig - Creates a ‘defconfig’ file, stripping out all of the symbols that were left as default values. This is very useful for debugging, and is how config files should be saved. - silentoldconfig - This evaluates the .config file the same way that the
-
Angel Pons (Code Review) -
Jonathan Zhang (Code Review)
-
Patrick Georgi (Code Review)