Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kyle Lin, Nick Vaccaro, Subrata Banik.
Yunlong Jia has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85512/comment/b4edb3ad_1d60c543?usp... :
PS1, Line 6: option DB_A 3
The name of the DB should clearly indicate the features. Using DB_A is misleading. […]
Done
https://review.coreboot.org/c/coreboot/+/85512/comment/2187631d_c0dc5dfd?usp... :
PS1, Line 268: probe TOUCH_PANEL TOUCH_PANEL_DISABLE
Please rename the options for TOUCH_PANEL as something like TOUCH_PANEL_I2C_HID and TOUCH_PANEL_I2C_ […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9
Gerrit-Change-Number: 85512
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jiping He
jiping.he@ecs.corp-partner.google.com
Gerrit-CC: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 16 Dec 2024 03:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyle Lin
kylelinck@google.com
Comment-In-Reply-To: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com